Clean Code for bundles/org.eclipse.jface.text #3293
Merged
+2,733
−1,533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
9 times, most recently
from
41d9bee to
03683f1
Compare
akurtakov
reviewed
Sep 25, 2025
...clipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java
Outdated
Show resolved
Hide resolved
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
03683f1 to
ab6b8d6
Compare
|
@laeubi This is simply non reviewable (even according to Github UI). Is there a way to run smaller set of changes for this bundle or should it be done manually so we got a PR that can actually be reviewed? |
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
ab6b8d6 to
88bee99
Compare
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
88bee99 to
d1391ba
Compare
akurtakov
reviewed
Sep 27, 2025
...clipse.jface.text/src/org/eclipse/jface/text/contentassist/AsyncCompletionProposalPopup.java
Outdated
Show resolved
Hide resolved
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
4 times, most recently
from
7ea3aa8 to
3bf0879
Compare
|
@akurtakov I think most of these changes are "Convert control statement bodies to block". I run this clean-up manually and push it in smaller batches so that this becomes reviewable. |
akurtakov
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
2 times, most recently
from
2b521f0 to
3373e3f
Compare
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
3373e3f to
2daca21
Compare
akurtakov
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
2daca21 to
1defe6a
Compare
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
2 times, most recently
from
5a9b96f to
2c6a902
Compare
|
Ups, sorry, clicked the default (merge) instead of the rebase. I can update this later tonight and remove the merge commit. @akurtakov is it possible to disable the "Update with merge" option from the webui? |
|
No idea . |
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
47441f5 to
153addf
Compare
|
Has been updated by the bot |
vogella
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
153addf to
4f86007
Compare
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
7 times, most recently
from
f9afe16 to
a57dc8b
Compare
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
3 times, most recently
from
3670d9b to
124b7d7
Compare
akurtakov
added a commit
to akurtakov/eclipse.platform.ui
that referenced
this pull request
Oct 22, 2025
A prep step for eclipse-platform#3293 . Makes sure that comments are not lost.
akurtakov
added a commit
that referenced
this pull request
Oct 22, 2025
A prep step for #3293 . Makes sure that comments are not lost.
eclipse-platform-bot
force-pushed
the
clean-code/bundles/org.eclipse.jface.text
branch
from
124b7d7 to
e21a637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following cleanups were applied: